Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: node 12 deprecation #1774

Merged
merged 3 commits into from Jul 26, 2023
Merged

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Jul 19, 2023

This is currently just a placeholder PR for efforts to push out a new major that drops Node 12 support and pulls in a couple of minor breaking changes for typings, and a new gax.

@feywind feywind added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 19, 2023
@feywind feywind requested review from a team as code owners July 19, 2023 19:26
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 19, 2023
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@feywind feywind merged commit d63d0ca into googleapis:node-12-eos Jul 26, 2023
5 of 13 checks passed
@feywind feywind deleted the node-12-deprecation branch July 26, 2023 18:45
@feywind
Copy link
Collaborator Author

feywind commented Jul 26, 2023

This is moved into the googleapis repo now, will re-open a new PR.

feywind added a commit that referenced this pull request Aug 2, 2023
* feat!: node 12 eos (#1774) - moving to googleapis

* feat!: bring in typing interface for Subscription events

* feat!: gax 4 updates - some of this will be regen'd, just testing

* fix!(deps): update dependency google-gax to v4 (#1780)

* fix!(deps): update dependency google-auth-library to v9 (#1776)

Co-authored-by: Megan Potter <57276408+feywind@users.noreply.github.com>

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* build: revert incorrect owlbot change

* deps!: update dependencies and kokoro files

* build: samples package.json should use the new major

* fix!: manually update testIam methods.. not sure why these didn't update

* build: make samples always use current version; update to 4.0.0

* build: update check config

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* build: let sample tests drive npm pack

---------

Co-authored-by: Mend Renovate <renovate@whitesourcesoftware.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant