Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update masks for topic should be snake case #1778

Merged
merged 3 commits into from Jul 26, 2023
Merged

fix: update masks for topic should be snake case #1778

merged 3 commits into from Jul 26, 2023

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Jul 25, 2023 •
edited

Fixes: #1587

@feywind feywind requested review from a team as code owners July 25, 2023 19:55
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Jul 25, 2023
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2023
alexander-fenster
alexander-fenster reviewed Jul 25, 2023
View reviewed changes
src/util.ts Outdated
* @private
*/
export function camelToSnake(input: string): string {
return input.replace(/[A-Z]/g, letter => `_${letter.toLowerCase()}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to double check what should happen with numbers. E. g. abc360Value - should it be abc_360_value or abc360_value? Ask me why I care :)

Copy link

@leahecole leahecole Jul 25, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I brought up in a 1-1 chat that I want to see a test so this would be a good test case too 😁

@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2023
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2023
@feywind feywind merged commit ba72638 into googleapis:main Jul 26, 2023
15 checks passed
@feywind feywind deleted the gh1587-update-mask branch July 26, 2023 17:22
@release-please release-please bot mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster approved these changes

@leahecole leahecole leahecole approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

topic(setMetadata): messageRetentionDuration not working
4 participants
@feywind @alexander-fenster @leahecole @yoshi-kokoro