Regression: publisher gRPC max recv set to 4MB

[dpcollins-google]

Environment details

• OS: Any (both OSX and ubuntu running on compute engine)
• Node.js version: 10 and 11
• npm version:
• @google-cloud/pubsub version: 0.23.0, 0.24.0

Steps to reproduce

1. Create a publisher which publishes continuously until a certain amount of bytes are outstanding (50MB for example)
2. Receive error from grpc channel Unhandled Rejection at: Promise Promise {
   Jan 29 18:22:29 cps-loadtest-cps-gcloud-node-publisher-16-12x3 startup-script: INFO startup-script-url: { Error: 8 RESOURCE_EXHAUSTED: Received message larger than max (7730750 vs. 4194304)
   Jan 29 18:22:29 cps-loadtest-cps-gcloud-node-publisher-16-12x3 startup-script: INFO startup-script-url: at Object.exports.createStatusError (/tmp/tmp.YqF8Ra5zwY/node_src/node_modules/grpc/src/common.js:91:15)
   Jan 29 18:22:29 cps-loadtest-cps-gcloud-node-publisher-16-12x3 startup-script: INFO startup-script-url: at Object.onReceiveStatus (/tmp/tmp.YqF8Ra5zwY/node_src/node_modules/grpc/src/client_interceptors.js:1204:28)
   Jan 29 18:22:29 cps-loadtest-cps-gcloud-node-publisher-16-12x3 startup-script: INFO startup-script-url: at InterceptingListener._callNext (/tmp/tmp.YqF8Ra5zwY/node_src/node_modules/grpc/src/client_interceptors.js:568:42)
   Jan 29 18:22:29 cps-loadtest-cps-gcloud-node-publisher-16-12x3 startup-script: INFO startup-script-url: at InterceptingListener.onReceiveStatus (/tmp/tmp.YqF8Ra5zwY/node_src/node_modules/grpc/src/client_interceptors.js:618:8)
   Jan 29 18:22:29 cps-loadtest-cps-gcloud-node-publisher-16-12x3 startup-script: INFO startup-script-url: at callback (/tmp/tmp.YqF8Ra5zwY/node_src/node_modules/grpc/src/client_interceptors.js:845:24)

This was previously addressed in googleapis/google-cloud-node#2190, and appears to be a regression from that.

[callmehiphop]

Looks like we forgot to remove the bound when we converted from plain grpc to gax. I'll get a fix out asap but in the meantime you should be able to do this

const pubsub = new PubSub({
  'grpc.max_send_message_length': -1,
});

[callmehiphop]

The fix for this is now available in v0.24.1