fix(typescript): pin grpc to previous working version #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 14 14
Lines 857 857
Branches 178 178
=======================================
Hits 839 839
Misses 2 2
Partials 16 16Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to grpc/grpc-node#883
Latest version of the gRPC extension results in a slew of TypeScript errors. I believe the culprit is the
@types/protobufjspackage (which is deprecated). I think the best course of action is to just pin it for now.