-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add .repo-metadata.json, start generating README.md #636
Conversation
samples/quickstart.js
Outdated
@@ -15,7 +15,7 @@ | |||
|
|||
'use strict'; | |||
|
|||
// [START pubsub_quickstart_create_topic] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is renaming this region tag to the standard quickstart
okay? CC: @sduskis, @JustinBeckwith, I wasn't sure how load bearing the region tag is, e.g., will this mean that we break samples on cloud.google.com
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 14 14
Lines 856 856
Branches 178 178
=======================================
Hits 838 838
Misses 2 2
Partials 16 16 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 14 14
Lines 856 856
Branches 178 178
=======================================
Hits 838 838
Misses 2 2
Partials 16 16 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with the nit about the region tag
samples/quickstart.js
Outdated
@@ -15,7 +15,7 @@ | |||
|
|||
'use strict'; | |||
|
|||
// [START pubsub_quickstart_create_topic] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds a
.repo-metadata.json
, which is used to automate publishing docs when new package versions are released.This PR also re-runs our automated README generation, which is based on
.repo-metadata.json
as well.I've left a couple questions for folks inline.