Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

feat!: library now uses v1 API surface #62

Merged
merged 2 commits into from
Feb 28, 2020
Merged

feat!: library now uses v1 API surface #62

merged 2 commits into from
Feb 28, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Feb 28, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 28, 2020
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #62 into master will decrease coverage by 76.53%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #62       +/-   ##
===========================================
- Coverage   94.12%   17.59%   -76.54%     
===========================================
  Files          18       20        +2     
  Lines        2521     4285     +1764     
  Branches       72        0       -72     
===========================================
- Hits         2373      754     -1619     
- Misses        147     3531     +3384     
+ Partials        1        0        -1
Impacted Files Coverage Δ
src/index.ts 0% <0%> (-100%) ⬇️
src/v1/index.ts 0% <0%> (ø)
src/v1/secret_manager_service_client.ts 0% <0%> (ø)
src/v1beta1/index.ts 0% <0%> (-100%) ⬇️
src/v1beta1/secret_manager_service_client.ts 0% <0%> (-91.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5628f54...a448d50. Read the comment docs.

Copy link

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super well versed in this one, but I don't see anything suspicious looking :)

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just please make sure we want to drop the beta

synth.py Show resolved Hide resolved
@bcoe bcoe merged commit a8368d4 into master Feb 28, 2020
@bcoe bcoe deleted the v1-launch branch February 28, 2020 19:42
@release-please release-please bot mentioned this pull request Feb 28, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants