Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime dependencies faulty declared as devDependencies. #1701

Closed
PerThoresson opened this issue Sep 2, 2022 · 0 comments · Fixed by #1704
Closed

Runtime dependencies faulty declared as devDependencies. #1701

PerThoresson opened this issue Sep 2, 2022 · 0 comments · Fixed by #1704
Assignees
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@PerThoresson
Copy link
Contributor

Some dependencies are declared as dev dependencies while they are actually run-time dependencies. This does not cause a problem with NPM currently as other dependencies include the missing ones.

However, when using together with Bazel and rules_js which isolate dependencies it breaks as they are not declared properly.

I've fixed the package.json to declare the dependencies in the correct way.

Thanks!

@PerThoresson PerThoresson added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 2, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
2 participants