fix(codec): use index to determine array struct member value #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Where the STRUCT value is an array, always determine inner member value using field index. STRUCT value is represented by var 'decoded'. Refs: googleapis#1774
surbhigarg92
approved these changes
Jan 19, 2023
surbhigarg92
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
surbhigarg92
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where the STRUCT value is an array, always determine inner member value using field index.
Error case is reproduced by the new
should decode array STRUCT value and inner memberstest case in test/codec.ts.Fixes #1774.
Appropriate docs were updated (if necessary)