Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Logic for retrying specifiied internal errors #1822

Merged
merged 4 commits into from Mar 17, 2023
Merged

fix: Logic for retrying specifiied internal errors #1822

merged 4 commits into from Mar 17, 2023

Conversation

surbhigarg92
Copy link
Contributor

Fixes #1808

@surbhigarg92 surbhigarg92 requested review from a team as code owners March 13, 2023 13:09
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Mar 13, 2023
olavloite
olavloite approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but with a small nit/question on why we are not using the generic method for the streaming function.

src/partial-result-stream.ts Outdated Show resolved Hide resolved
@surbhigarg92 surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit f915bd1 into googleapis:main Mar 17, 2023
15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 17, 2023
@release-please release-please bot mentioned this pull request Mar 17, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 6, 2023
@release-please
chore(main): release 6.8.0 (#1821)
23ec060 
🤖 I have created a release *beep* *boop*
---


## [6.8.0](https://togithub.com/googleapis/nodejs-spanner/compare/v6.7.2...v6.8.0) (2023-04-06)


### Features

* Adding new fields for Serverless analytics ([#1816](https://togithub.com/googleapis/nodejs-spanner/issues/1816)) ([2a6ca6f](https://togithub.com/googleapis/nodejs-spanner/commit/2a6ca6f09215752f9451d625ac02837e9d70b66a))


### Bug Fixes

* Begin transaction foes not handle error ([#1833](https://togithub.com/googleapis/nodejs-spanner/issues/1833)) ([6ecd366](https://togithub.com/googleapis/nodejs-spanner/commit/6ecd366da7183d502c710cb5c879984c276b12db))
* Correcting the proto field Id for field data_boost_enabled ([#1827](https://togithub.com/googleapis/nodejs-spanner/issues/1827)) ([7f6d4cc](https://togithub.com/googleapis/nodejs-spanner/commit/7f6d4ccce9269197312f2d795ef854e1789e8fce))
* Logic for retrying specifiied internal errors ([#1822](https://togithub.com/googleapis/nodejs-spanner/issues/1822)) ([f915bd1](https://togithub.com/googleapis/nodejs-spanner/commit/f915bd16cf7e817243e46a319b3e6f270b24bf68)), closes [#1808](https://togithub.com/googleapis/nodejs-spanner/issues/1808)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@asthamohta asthamohta asthamohta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: 13 INTERNAL: Received RST_STREAM not retried for Commit
3 participants
@surbhigarg92 @olavloite @asthamohta