fix: idwaiter with multiple requests #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
surbhigarg92
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
reviewed
Aug 29, 2023
product-auto-label
bot
added
size: m
surbhigarg92
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
surbhigarg92
added
the
automerge
olavloite
approved these changes
Aug 30, 2023
| @@ -101,7 +102,7 @@ export interface ReadRequest extends RequestOptions { | |||
| keys?: string[] | string[][]; | |||
| ranges?: KeyRange[]; | |||
| keySet?: spannerClient.spanner.v1.IKeySet | null; | |||
| limit?: number | Long | null; | |||
| limit?: number | Long | string | null; | |||
There was a problem hiding this comment.
This seems like an unrelated change?
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
🤖 I have created a release *beep* *boop* --- ## [7.0.0](https://togithub.com/googleapis/nodejs-spanner/compare/v6.16.0...v7.0.0) (2023-08-30) ### ⚠ BREAKING CHANGES * upgrade to Node 14 ([#1890](https://togithub.com/googleapis/nodejs-spanner/issues/1890)) ### Bug Fixes * Idwaiter with multiple requests ([#1910](https://togithub.com/googleapis/nodejs-spanner/issues/1910)) ([83dd1f8](https://togithub.com/googleapis/nodejs-spanner/commit/83dd1f8201d07898bd3ddff9e339dfbcef7d7ace)) ### Miscellaneous Chores * Upgrade to Node 14 ([#1890](https://togithub.com/googleapis/nodejs-spanner/issues/1890)) ([0024772](https://togithub.com/googleapis/nodejs-spanner/commit/0024772b750de404cd44771e320fe89cd430f064)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1908 🦕