Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database.getTransaction() not accepting RunTransactionOptions #2021

Closed
harshachinta opened this issue Mar 18, 2024 · 0 comments · Fixed by #2028
Closed

database.getTransaction() not accepting RunTransactionOptions #2021

harshachinta opened this issue Mar 18, 2024 · 0 comments · Fixed by #2028
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@harshachinta
Copy link
Contributor

RunTransactionOptions has a property optimisticLock mode where a lock is acquired during a commit. More details here.

This option is missing in database.getTransaction().
@harshachinta harshachinta added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 18, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Mar 18, 2024
@alkatrivedi alkatrivedi mentioned this issue Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: optimisticLock option for getTransaction method alkatrivedi/nodejs-spanner
1 participant
@harshachinta