Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

feat!: drop node8 support #562

Merged
merged 3 commits into from
Apr 1, 2020
Merged

feat!: drop node8 support #562

merged 3 commits into from
Apr 1, 2020

Conversation

alexander-fenster
Copy link
Contributor

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2020
@xiaozhenliu-gg5 xiaozhenliu-gg5 added the automerge Merge the pull request once unit tests and other checks pass. label Mar 31, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

2 similar comments
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

2 similar comments
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #562 into master will increase coverage by 12.62%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #562       +/-   ##
===========================================
+ Coverage   83.86%   96.48%   +12.62%     
===========================================
  Files          14        7        -7     
  Lines        3365     1281     -2084     
  Branches       87       95        +8     
===========================================
- Hits         2822     1236     -1586     
+ Misses        541       43      -498     
  Partials        2        2
Impacted Files Coverage Δ
src/helpers.ts 97.67% <100%> (ø) ⬆️
src/v1/speech_client.ts 96.42% <100%> (+1.85%) ⬆️
src/v1p1beta1/speech_client.ts 96.44% <100%> (+2.05%) ⬆️
samples/quickstart.js
samples/transcribeContextClasses.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4dc8c...1edb2eb. Read the comment docs.

@alexander-fenster alexander-fenster merged commit 29d0f3f into master Apr 1, 2020
@alexander-fenster alexander-fenster deleted the finally-drop-node8 branch April 1, 2020 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants