Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

fix: handle fallback option properly #608

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Jun 12, 2020

Fixes #547.

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
…secrets.sh

Co-authored-by: Benjamin E. Coe <bencoe@google.com>

Source-Author: BenWhitehead <BenWhitehead@users.noreply.github.com>
Source-Date: Wed Jun 10 22:24:28 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: e7034945fbdc0e79d3c57f6e299e5c90b0f11469
Source-Link: googleapis/synthtool@e703494
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 12, 2020
@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #608 into master will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
+ Coverage   95.89%   96.28%   +0.38%     
==========================================
  Files           7        7              
  Lines        1487     1481       -6     
  Branches       92       90       -2     
==========================================
  Hits         1426     1426              
+ Misses         59       53       -6     
  Partials        2        2              
Impacted Files Coverage Δ
src/v1/speech_client.ts 95.97% <100.00%> (+0.50%) ⬆️
src/v1p1beta1/speech_client.ts 96.68% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3ac050...9861f84. Read the comment docs.

@alexander-fenster alexander-fenster changed the title [CHANGE ME] Re-generated to pick up changes from synthtool. fix: handle fallback option properly Jun 12, 2020
@alexander-fenster alexander-fenster merged commit 2e8558c into master Jun 12, 2020
@alexander-fenster alexander-fenster deleted the autosynth-synthtool branch June 12, 2020 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement. context: partial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't work in electron (or with fallback set to true)
3 participants