-
Notifications
You must be signed in to change notification settings - Fork 290
fix(samples): end stream before destroying it #611
Conversation
I've been getting this error until I put call of end() for the stream before destroying it. `API request error 14 UNAVAILABLE: 408:Request Timeout`
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 馃摑 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
鈩癸笍 Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #611 +/- ##
=======================================
Coverage 94.90% 94.90%
=======================================
Files 9 9
Lines 1530 1530
Branches 90 90
=======================================
Hits 1452 1452
Misses 76 76
Partials 2 2 Continue to review full report at Codecov.
|
@googlebot I signed it! |
CLAs look good, thanks! 鈩癸笍 Googlers: Go here for more info. |
@Wirnex It's not immediately apparent to me why this would help suppress that error. @alexander-fenster can you shine any light on what might be happening here? |
Let me see if I can reproduce the failure. |
Thanks @Wirnex, and sorry for delay! |
I've been getting this error until I put call of end() for the stream before destroying it.
API request error 14 UNAVAILABLE: 408:Request Timeout
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 馃