Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

fix(samples): end stream before destroying it #611

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

Wirnex
Copy link
Contributor

@Wirnex Wirnex commented Jun 18, 2020

I've been getting this error until I put call of end() for the stream before destroying it.
API request error 14 UNAVAILABLE: 408:Request Timeout

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

I've been getting this error until I put call of end() for the stream before destroying it.
`API request error 14 UNAVAILABLE: 408:Request Timeout`
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #611 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files           9        9           
  Lines        1530     1530           
  Branches       90       90           
=======================================
  Hits         1452     1452           
  Misses         76       76           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 617f25a...26c47f7. Read the comment docs.

@Wirnex
Copy link
Contributor Author

Wirnex commented Jun 19, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

鈩癸笍 Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 19, 2020
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 19, 2020
@bcoe
Copy link
Contributor

bcoe commented Jun 19, 2020

@Wirnex It's not immediately apparent to me why this would help suppress that error. @alexander-fenster can you shine any light on what might be happening here?

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 19, 2020
@alexander-fenster
Copy link
Contributor

Let me see if I can reproduce the failure.

@product-auto-label product-auto-label bot added the api: speech Issues related to the googleapis/nodejs-speech API. label Aug 21, 2020
@alexander-fenster alexander-fenster requested a review from a team as a code owner September 1, 2020 22:22
@alexander-fenster alexander-fenster added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 1, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 1, 2020
@alexander-fenster alexander-fenster changed the title End stream before destroying it fix(samples): end stream before destroying it Sep 1, 2020
@alexander-fenster
Copy link
Contributor

Thanks @Wirnex, and sorry for delay!

@alexander-fenster alexander-fenster merged commit 2b3a220 into googleapis:master Sep 1, 2020
@Wirnex Wirnex deleted the patch-1 branch September 2, 2020 06:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: speech Issues related to the googleapis/nodejs-speech API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants