Constant value delimiter for directory option for bucket.getFiles #1343
Labels
api: storage
Issues related to the googleapis/nodejs-storage API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
I was studying bucket.getFiles() options and found a property called "directory". I couldn't understand what this did or how it should work so I examined the source code and came to this source:
https://github.com/googleapis/nodejs-storage/blob/master/src/bucket.ts#L2234
at that location, we find the implementation of the directory option property. If I am reading it correctly, it appears to assume that the delimiter will be fixed to be '/'. While I fully agree that I can't imagine anyone wanting a delimiter other than this, our documentation does allow for arbitrary delimiters as specified by the delimiter option. This report asks for y'all to consider whether or not the "directory" option needs to consider the value that the programmer passed in for "delimiter".
The text was updated successfully, but these errors were encountered: