Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant value delimiter for directory option for bucket.getFiles #1343

Closed
kolban-google opened this issue Nov 23, 2020 · 0 comments · Fixed by #1370
Closed

Constant value delimiter for directory option for bucket.getFiles #1343

kolban-google opened this issue Nov 23, 2020 · 0 comments · Fixed by #1370
Assignees
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@kolban-google
Copy link

I was studying bucket.getFiles() options and found a property called "directory". I couldn't understand what this did or how it should work so I examined the source code and came to this source:

https://github.com/googleapis/nodejs-storage/blob/master/src/bucket.ts#L2234

at that location, we find the implementation of the directory option property. If I am reading it correctly, it appears to assume that the delimiter will be fixed to be '/'. While I fully agree that I can't imagine anyone wanting a delimiter other than this, our documentation does allow for arbitrary delimiters as specified by the delimiter option. This report asks for y'all to consider whether or not the "directory" option needs to consider the value that the programmer passed in for "delimiter".

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Nov 23, 2020
@kolban-google kolban-google changed the title Fixed delimiter for directory option for bucket.getFiles Constant value delimiter for directory option for bucket.getFiles Nov 23, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Nov 23, 2020
@shaffeeullah shaffeeullah added the type: question Request for information or clarification. Not an issue. label Nov 24, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Nov 24, 2020
@shaffeeullah shaffeeullah added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: question Request for information or clarification. Not an issue. labels Dec 16, 2020
@shaffeeullah shaffeeullah self-assigned this Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
3 participants