Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-chunk Upload Without contentLength Can Hang When fileSize % chunkSize != 0 #2073

Closed
danielbankhead opened this issue Sep 21, 2022 · 0 comments · Fixed by #2074
Closed

Multi-chunk Upload Without contentLength Can Hang When fileSize % chunkSize != 0 #2073

danielbankhead opened this issue Sep 21, 2022 · 0 comments · Fixed by #2074
Assignees
@danielbankhead
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@danielbankhead
Copy link
Member

A multi-chunk resumable upload hangs when the chunkSize is not evenly divisible by the file size when a contentLength is not provided.

ACs:

  • Fix upload logic for this scenario
  • Fix unit test(s)
  • Add integration tests for the following scenarios:
    • fileSize % chunkSize != 0
    • fileSize < chunkSize
@danielbankhead danielbankhead added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 21, 2022
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Sep 21, 2022
@danielbankhead danielbankhead self-assigned this Sep 21, 2022
@danielbankhead danielbankhead mentioned this issue Sep 21, 2022
Merged
@danielbankhead danielbankhead added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielbankhead danielbankhead

Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Determine Content-Length Before Attempting Multi-chunk Upload googleapis/nodejs-storage
1 participant
@danielbankhead