-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ts): improve return types for response metadata #666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me Metadata
reads much better than r.Response
.
src/bucket.ts
Outdated
@@ -176,28 +174,28 @@ export interface GetBucketOptions extends GetConfig { | |||
userProject?: string; | |||
} | |||
|
|||
export type GetBucketResponse = [Bucket, request.Response]; | |||
export type GetBucketResponse = [Bucket, Metadata]; | |||
|
|||
export interface GetBucketCallback { | |||
(err: ApiError|null, bucket: Bucket|null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like the linting gods might be angry.
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 9 9
Lines 921 921
Branches 100 100
=======================================
Hits 903 903
Misses 9 9
Partials 9 9
Continue to review full report at Codecov.
|
As a bonus, drops dependencies on
teeny-request
and@types/request