Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout should be configurable as StorageOption #733

Closed
ildella opened this issue Jun 7, 2019 · 4 comments
Closed

Timeout should be configurable as StorageOption #733

ildella opened this issue Jun 7, 2019 · 4 comments
Assignees
@AVaksman
Labels
api: storage Issues related to the googleapis/nodejs-storage API. help wanted We'd love to have community involvement on this issue. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ildella
Copy link

ildella commented Jun 7, 2019

There is no way to configure the timeout for a storage call.
In 2.5 the StorageOptions object that is passed as parameter on a new Storage() does not have any field for that.

In the python documentation there is urlfetch_timeout for this.

It would be great to have the same option in the nodejs library as well.
@ildella ildella changed the title Timeout should not configurable as StorageOption Timeout should be configurable as StorageOption Jun 7, 2019
@JustinBeckwith JustinBeckwith added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jun 7, 2019
@AVaksman AVaksman mentioned this issue Jun 27, 2019
Closed
3 tasks
@AVaksman AVaksman mentioned this issue Jul 29, 2019
Merged
3 tasks
@stephenplusplus
Copy link
Contributor

@AVaksman this appears to have been addressed in googleapis/nodejs-common#455. Is more work required, or is this feature live for new Storage downloads?

@stephenplusplus
Copy link
Contributor

Ping @AVaksman for clarity!

@AVaksman
Copy link
Contributor

Work in progress to expose timeouts to user on a high level.

@jkwlui jkwlui added the help wanted We'd love to have community involvement on this issue. label Oct 23, 2019
@ildella ildella closed this as completed Nov 12, 2019
@google-cloud-label-sync google-cloud-label-sync bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jan 31, 2020
@moshekrup
Copy link

moshekrup commented Feb 9, 2021 •
edited

Any updates for this issue?
Is there a way to define the timeout for the storage request?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AVaksman AVaksman

Labels
api: storage Issues related to the googleapis/nodejs-storage API. help wanted We'd love to have community involvement on this issue. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ildella @JustinBeckwith @stephenplusplus @jkwlui @AVaksman @moshekrup