Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling automatic decompression when downloading files #827

Closed
martincognite opened this issue Aug 23, 2019 · 0 comments · Fixed by #850
Closed

Allow disabling automatic decompression when downloading files #827

martincognite opened this issue Aug 23, 2019 · 0 comments · Fixed by #850
Assignees
@jkwlui
Labels
api: storage Issues related to the googleapis/nodejs-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@martincognite
Copy link

Is your feature request related to a problem? Please describe.
When sending files downloaded from GCS back to the user, it would be nice if there existed an option to disable decompressing files that are compressed at rest. Currently we end up decompressing on download (well, this library does) and compressing on the way out to clients again.

Describe the solution you'd like
A flag in file.download() that can disable gzip compression (I absolutely think decompressing should be the default).
@martincognite martincognite changed the title Allow options to not decompress gzip when downloading files Allow disabling automatic decompression when downloading files Aug 23, 2019
@AVaksman AVaksman added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Aug 23, 2019
@AVaksman AVaksman mentioned this issue Sep 11, 2019
Merged
3 tasks
@google-cloud-label-sync google-cloud-label-sync bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkwlui jkwlui

Labels
api: storage Issues related to the googleapis/nodejs-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add flag to allow disabling auto decompression by client AVaksman/nodejs-storage
3 participants
@jkwlui @AVaksman @martincognite