Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc outdated: option "keepAcl" in file#copy is not in action #836

Closed
kevinresol opened this issue Aug 28, 2019 · 1 comment · Fixed by #837
Closed

Doc outdated: option "keepAcl" in file#copy is not in action #836

kevinresol opened this issue Aug 28, 2019 · 1 comment · Fixed by #837
Assignees
@jkwlui
Labels
api: storage Issues related to the googleapis/nodejs-storage API. triage me I really want to be triaged.

Comments

@kevinresol
Copy link

According to #21 that feature is not supported. But it appears in the documentation.

nodejs-storage/src/file.ts

Line 862 in 840eb6a

* @property {string} [keepAcl] Retain the ACL for the new file.

@AVaksman AVaksman mentioned this issue Aug 28, 2019
Merged
3 tasks
@AVaksman
Copy link
Contributor

@kevinresol Thank you reporting it. Removing it in #837

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Aug 29, 2019
@AVaksman AVaksman mentioned this issue Sep 5, 2019
Merged
3 tasks
@google-cloud-label-sync google-cloud-label-sync bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkwlui jkwlui

Labels
api: storage Issues related to the googleapis/nodejs-storage API. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

revert: remove unsupported keepAcl param from file#copy AVaksman/nodejs-storage
4 participants
@kevinresol @jkwlui @AVaksman @yoshi-automation