Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

fix: get autosynth working again #387

Merged
merged 2 commits into from
Nov 19, 2019
Merged

fix: get autosynth working again #387

merged 2 commits into from
Nov 19, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Nov 19, 2019

Should get autosynth working again, I noticed a few issues that we will want to address in the upstream generator:

  1. webpack.config.js generates with linting issues.
  2. the system tests generate with the name translations rather than @google-cloud/translate.
  3. the system tests have linting issues:
/usr/local/google/home/bencoe/google/nodejs-translate/system-test/fixtures/sample/src/index.js
  19:29  error  "@google-cloud/translate" is not found                                                            node/no-missing-require
  22:9   error  'translationServiceClient' is assigned a value but never used                                     no-unused-vars
  23:15  error  Replace `"translationServiceClient·was·created!"` with `'translationServiceClient·was·created!'`  prettier/prett

fixes #379

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2019
@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #387 into master will decrease coverage by 0.86%.
The diff coverage is 95.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
- Coverage   96.78%   95.92%   -0.87%     
==========================================
  Files           6        6              
  Lines        2706     3309     +603     
  Branches       66       76      +10     
==========================================
+ Hits         2619     3174     +555     
- Misses         84      134      +50     
+ Partials        3        1       -2
Impacted Files Coverage Δ
src/v2/index.ts 99.5% <100%> (+0.02%) ⬆️
src/v3/translation_service_client.ts 92.7% <94.3%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b848d01...6be0cd1. Read the comment docs.

@alexander-fenster
Copy link
Contributor

re: system test name - will be taken care of by googleapis/gapic-generator-typescript#134 (we just need to give a hint to the generator about the package name to use).

@bcoe bcoe merged commit c226e58 into master Nov 19, 2019
@bcoe bcoe deleted the fix-synth-2 branch November 19, 2019 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synth generation is broken
4 participants