This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
feat: convert v3beta1 to TypeScript #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
=========================================
- Coverage 95.92% 93.9% -2.02%
=========================================
Files 6 6
Lines 3309 3399 +90
Branches 76 123 +47
=========================================
+ Hits 3174 3192 +18
- Misses 134 205 +71
- Partials 1 2 +1
Continue to review full report at Codecov.
|
JustinBeckwith
suggested changes
Nov 22, 2019
| @@ -14,54 +14,34 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
So that's a problem, no? We have to expose the jsdoc for the still relevant v2 version of the API.
| version=version) | ||
| s.copy(library, excludes=['README.md', 'package.json', 'src/index.ts']) |
JustinBeckwith
approved these changes
Nov 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the last part of the library, the
v3beta1API, to TypeScript. Also, making sure the common resources (such aslocation) are correctly processed for bothv3andv3beta1.