Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LICENSE file not included in source distribution on PyPI #141

Closed
tswast opened this issue Oct 5, 2020 · 2 comments
Closed

LICENSE file not included in source distribution on PyPI #141

tswast opened this issue Oct 5, 2020 · 2 comments
Assignees
@busunkim96
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.

Comments

@tswast
Copy link

tswast commented Oct 5, 2020

It's a best practice to include a LICENSE file in the source distribution. This way licenses can be audited by automated tooling.

Also, this is recommended to pass the linter on conda-forge.
@tswast tswast mentioned this issue Oct 5, 2020
Merged
7 tasks
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Oct 6, 2020
@marcelotrevisani marcelotrevisani mentioned this issue Oct 8, 2020
Closed
@busunkim96
Copy link
Contributor

@software-dov Unless you have any objections I'll open a PR to add a MANIFEST.in. It will also take care of #143.

https://packaging.python.org/guides/using-manifest-in/

@danoscarmike danoscarmike added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed triage me I really want to be triaged. labels Oct 8, 2020
@busunkim96 busunkim96 mentioned this issue Oct 8, 2020
Merged
@busunkim96
Copy link
Contributor

Closed by #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tswast @danoscarmike @busunkim96 @yoshi-automation