Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update aiplatform SDK arrangement for Sphinx #1163

Merged
merged 9 commits into from May 11, 2022
Merged

Conversation

dandhlee
Copy link
Contributor

aiplatform.rst file left on its on under docs/ directory caused it to appear as an extra entry, as https://cloud.google.com/python/docs/reference/aiplatform/latest/aiplatform. However, the page itself is just the services SDK for google/cloud/aiplatform directory without additional content. Rearranging the sphinx arrangement to remove this extra page while keeping the rest of the documentation intact.

Verified that the documentation produced looks correct.

Fixes b/208866336 🦕

@dandhlee dandhlee requested review from a team as code owners April 13, 2022 00:27
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 13, 2022
@dandhlee dandhlee changed the title Remove markdown sdk docs: update aiplatform SDK arrangement for Sphinx Apr 13, 2022
@sasha-gitg sasha-gitg added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Apr 20, 2022
@product-auto-label product-auto-label bot added the api: vertex-ai Issues related to the googleapis/python-aiplatform API. label May 5, 2022
@sararob sararob added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 5, 2022
@dandhlee
Copy link
Contributor Author

dandhlee commented May 9, 2022

Spoke with @rosiezou, I'll review the updates since this PR has been slightly out of date then request for review again.

@dandhlee dandhlee self-assigned this May 9, 2022
@dandhlee dandhlee assigned rosiezou and unassigned dandhlee May 10, 2022
@dandhlee dandhlee removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 10, 2022
@dandhlee
Copy link
Contributor Author

Double checked, no changes on the docs directory structure.

@sararob sararob added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 10, 2022
@rosiezou rosiezou merged commit e9510ea into main May 11, 2022
@rosiezou rosiezou deleted the remove_markdown_sdk branch May 11, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants