Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow users to specify timestamp split for vertex forecasting #1187

Merged
merged 2 commits into from May 3, 2022
Merged

feat: Allow users to specify timestamp split for vertex forecasting #1187

merged 2 commits into from May 3, 2022

Conversation

TheMichaelHu
Copy link
Contributor

@TheMichaelHu TheMichaelHu commented Apr 27, 2022 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/230009255 馃

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 27, 2022
@sasha-gitg sasha-gitg requested a review from ivanmkc April 27, 2022 21:47
@sasha-gitg sasha-gitg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2022
ivanmkc
ivanmkc approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@ivanmkc ivanmkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheMichaelHu TheMichaelHu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 3, 2022
@TheMichaelHu TheMichaelHu added the automerge Merge the pull request once unit tests and other checks pass. label May 3, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit ee49e00 into googleapis:main May 3, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 3, 2022
@release-please release-please bot mentioned this pull request May 3, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanmkc ivanmkc ivanmkc approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TheMichaelHu @ivanmkc @sasha-gitg @yoshi-kokoro