fix: Pinned protobuf to prevent issues with pb files. #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we rely on dependencies like proto-plus-python to select a protobuf library version. However, if they select an incompatible version, it can lead to issues like #1257
product-auto-label
bot
added
size: xs
ivanmkc
changed the title
parthea
approved these changes
May 31, 2022
|
@sararob, Please could you review/approve? |
parthea
reviewed
May 31, 2022
|
LGTM once we confirm system tests pass. |
samgoodman
approved these changes
Jun 6, 2022
samgoodman
approved these changes
Jun 6, 2022
rosiezou
pushed a commit
that referenced
this pull request
Jun 16, 2022
* Pinned protobuf to prevent issues with pb files. Currently, we rely on dependencies like proto-plus-python to select a protobuf library version. However, if they select an incompatible version, it can lead to issues like #1257 * fix: Added upper limits for proto-plus + packaging * Added testing constraint Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Sam Goodman <stgoodman123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we rely on dependencies like proto-plus-python to select a protobuf library version.
However, if they select an incompatible version, it can lead to issues like #1257
Additionally, proto-plus and packaging had upper version limits added to prevent future breaking changes.
Prohibited versions were chosen from https://pypi.org/project/packaging/#history and https://pypi.org/project/proto-plus/#history and represent the next major release.