Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change endpoint update method to return resource #1409

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

sararob
Copy link
Contributor

@sararob sararob commented Jun 6, 2022

Fixes endpoint update method so it returns the resource and not an LRO.

Fixes b/235084784 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Jun 6, 2022
@sararob sararob changed the title fix endpoint update method fix: change endpoint update method to return resource Jun 6, 2022
@sararob sararob requested a review from sasha-gitg June 6, 2022 15:47
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
@sasha-gitg
Copy link
Member

Please update or add unit tests as well.

@sararob sararob merged commit 44e279b into googleapis:main Jun 6, 2022
rosiezou pushed a commit that referenced this pull request Jun 16, 2022
* fix: change endpoint update method to return resource

* fix: update unit tests for endpoint.update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants