Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add input artifact when creating a pipeline #1593

Merged
merged 26 commits into from Sep 6, 2022
Merged

feat: add input artifact when creating a pipeline #1593

merged 26 commits into from Sep 6, 2022

Conversation

rui5i
Copy link
Contributor

@rui5i rui5i commented Aug 12, 2022 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1592 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Aug 12, 2022
@sararob sararob self-requested a review August 12, 2022 20:14
sararob
sararob reviewed Aug 12, 2022
View reviewed changes
Copy link
Contributor

@sararob sararob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this! Do you have an example pipeline that takes an input artifact uri as a parameter? I think that would help me understand how this feature will be used in the SDK.

google/cloud/aiplatform/pipeline_jobs.py Outdated Show resolved Hide resolved
@rui5i rui5i changed the title Add input artifact when creating a pipeline feet: add input artifact when creating a pipeline Aug 17, 2022
@rui5i rui5i changed the title feet: add input artifact when creating a pipeline feat: add input artifact when creating a pipeline Aug 17, 2022
@rui5i rui5i requested a review from a team as a code owner August 17, 2022 18:28
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 17, 2022
jaycee-li
jaycee-li requested changes Aug 25, 2022
View reviewed changes
tests/unit/aiplatform/test_pipeline_jobs.py Outdated Show resolved Hide resolved
tests/unit/aiplatform/test_pipeline_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/pipeline_jobs.py Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Aug 25, 2022
@rui5i
Copy link
Contributor Author

rui5i commented Aug 25, 2022

/test

SinaChavoshi
SinaChavoshi approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! lgtm.

google/cloud/aiplatform/pipeline_jobs.py Show resolved Hide resolved
@jaycee-li jaycee-li added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2022
@jaycee-li jaycee-li added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2022
@jaycee-li jaycee-li added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2022
@jaycee-li jaycee-li added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2022
@jaycee-li jaycee-li added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2022
@jaycee-li jaycee-li added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2022
@jaycee-li jaycee-li added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2022
@jaycee-li jaycee-li merged commit 2cf9fe6 into googleapis:main Sep 6, 2022
@release-please release-please bot mentioned this pull request Sep 6, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
@release-please release-please bot mentioned this pull request Aug 25, 2023
Closed
@release-please release-please bot mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Ark-kun left review comments

@sararob sararob sararob left review comments

@SinaChavoshi SinaChavoshi SinaChavoshi approved these changes

@jaycee-li jaycee-li jaycee-li approved these changes

Assignees
No one assigned
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support input artifacts when creating pipeline job
6 participants
@rui5i @Ark-kun @sararob @SinaChavoshi @jaycee-li @yoshi-kokoro