Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding Python 3.10 support + updating google-vizier version #1644

Merged
merged 13 commits into from Sep 12, 2022

Conversation

nayaknishant
Copy link
Contributor

@nayaknishant nayaknishant commented Sep 6, 2022

Hey @parthea, I think we're ready to support Python version 3.10 (TensorFlow now supports Python 3.10). Is there more to do for 3.10 support other than adding the extra line to setup.py (I'm assuming this change will automatically update the related files) or will I need to manually add to CONTRIBUTING.rst, noxfile.py, and owlbot.py (according to #831)?

Thanks,
Nishant

@nayaknishant nayaknishant requested a review from a team as a code owner September 6, 2022 22:15
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Sep 6, 2022
@nayaknishant
Copy link
Contributor Author

It seems like I have to manually add in the changes, I'll do that now.

@nayaknishant nayaknishant requested a review from a team as a code owner September 6, 2022 22:29
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 6, 2022
@parthea
Copy link
Contributor

parthea commented Sep 7, 2022

Hi @nayaknishant, Please update this line to update the templated files and then add the owlbot: run label

unit_test_python_versions=["3.7", "3.8", "3.9"],

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022
@nayaknishant
Copy link
Contributor Author

Thanks @parthea. I'm now running into a 3.10 unit test issue:

ERROR: Could not find a version that satisfies the requirement pytype==2022.3.8 (from google-vizier) (from versions: 2018.5.14, 2018.5.15, 2018.5.22, 2018.5.22.1, 2018.6.5, 2018.6.15, 2018.6.18, 2018.6.19, 2018.7.13, 2018.8.10, 2018.9.7, 2018.9.7.1, 2018.9.18, 2018.9.19, 2018.9.25, 2018.9.26, 2018.10.30, 2018.11.6, 2018.12.11, 2018.12.21, 2019.1.18, 2019.1.30, 2019.2.13, 2019.3.1, 2019.3.8, 2019.3.15, 2019.3.21, 2019.3.27, 2019.4.2, 2019.4.2.1, 2019.4.5, 2019.4.12, 2019.4.19, 2019.4.26, 2019.5.6, 2019.5.8, 2019.5.15, 2019.5.24, 2019.5.31, 2019.6.21, 2019.6.28, 2019.7.11, 2019.7.26, 2019.7.30, 2019.8.9, 2019.8.29, 2019.9.6, 2019.9.17, 2019.10.17, 2019.11.27, 2019.12.6, 2019.12.17, 2020.1.7, 2020.1.8, 2020.1.24, 2020.2.6, 2022.4.15, 2022.4.22, 2022.4.26, 2022.5.5, 2022.5.10, 2022.5.19, 2022.6.6, 2022.6.14, 2022.6.23, 2022.6.30, 2022.7.18, 2022.7.26, 2022.8.3, 2022.8.17, 2022.8.23, 2022.8.30)
ERROR: No matching distribution found for pytype==2022.3.8

@nayaknishant
Copy link
Contributor Author

@halio-g any insight on this error? I think it's related to the google-vizier package for Python 3.10

@nayaknishant nayaknishant changed the title feat: adding Python 3.10 support feat: adding Python 3.10 support + updating google-vizier version Sep 7, 2022
@nayaknishant nayaknishant requested review from halio-g and removed request for sasha-gitg September 8, 2022 16:44
@rosiezou rosiezou added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 8, 2022
Copy link
Contributor

@halio-g halio-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Vizier change

@rosiezou rosiezou removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 8, 2022
@nayaknishant nayaknishant added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@nayaknishant nayaknishant removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@nayaknishant nayaknishant merged commit f4766dc into googleapis:main Sep 12, 2022
@sasha-gitg sasha-gitg mentioned this pull request Sep 28, 2022
4 tasks
@Ark-kun Ark-kun mentioned this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants