Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix endpoint parsing in ModelDeploymentMonitoringJob.update #1671

Merged
merged 31 commits into from Sep 29, 2022
Merged

fix: fix endpoint parsing in ModelDeploymentMonitoringJob.update #1671

merged 31 commits into from Sep 29, 2022

Conversation

rosiezou
Copy link
Contributor

Also modifying existing system test to exercise previously timed-out code path

@rosiezou rosiezou requested a review from a team as a code owner September 16, 2022 04:49
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Sep 16, 2022
sasha-gitg
sasha-gitg requested changes Sep 16, 2022
View reviewed changes
tests/system/aiplatform/test_model_monitoring.py Show resolved Hide resolved
tests/system/aiplatform/test_model_monitoring.py Outdated Show resolved Hide resolved
tests/system/aiplatform/test_model_monitoring.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/jobs.py Outdated Show resolved Hide resolved
@rosiezou rosiezou self-assigned this Sep 16, 2022
@rosiezou rosiezou mentioned this pull request Sep 20, 2022
Closed
sasha-gitg
sasha-gitg requested changes Sep 20, 2022
View reviewed changes
tests/system/aiplatform/test_model_monitoring.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/jobs.py Show resolved Hide resolved
sasha-gitg
sasha-gitg requested changes Sep 22, 2022
View reviewed changes
tests/system/aiplatform/test_model_monitoring.py Outdated Show resolved Hide resolved
tests/system/aiplatform/test_model_monitoring.py Outdated Show resolved Hide resolved
tests/system/aiplatform/test_model_monitoring.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/jobs.py Outdated Show resolved Hide resolved
tests/unit/aiplatform/test_jobs.py Outdated Show resolved Hide resolved
tests/unit/aiplatform/test_jobs.py Outdated Show resolved Hide resolved
tests/unit/aiplatform/test_jobs.py Outdated Show resolved Hide resolved
This was referenced Sep 22, 2022
Closed
Closed
Closed
@sasha-gitg sasha-gitg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2022
sasha-gitg
sasha-gitg approved these changes Sep 27, 2022
View reviewed changes
tests/unit/aiplatform/test_jobs.py Outdated Show resolved Hide resolved
tests/unit/aiplatform/test_jobs.py Show resolved Hide resolved
@rosiezou rosiezou merged commit 186872d into main Sep 29, 2022
@rosiezou rosiezou deleted the mm-bugfix branch September 29, 2022 08:18
@release-please release-please bot mentioned this pull request Sep 29, 2022
Merged
@rosiezou rosiezou mentioned this pull request Sep 29, 2022
Closed
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
@release-please release-please bot mentioned this pull request Aug 25, 2023
Closed
@release-please release-please bot mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

Assignees

@rosiezou rosiezou

Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rosiezou @sasha-gitg @yoshi-kokoro