Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable feature store online serving #918

Merged

Conversation

morgandu
Copy link
Contributor

@morgandu morgandu commented Dec 17, 2021

  • Added _instantiate_featurestore_online_client, and read method in EntityType class to enable feature store online serving
  • Enabled construct Pandas DataFrame for online serving result
  • Added unit tests
  • Added integration tests

@morgandu morgandu changed the title feat: add read in EntityType class to enable Featurestore Online Serving feat: enable feature store online serving; add read method in EntityType class for reading entities feature values Dec 17, 2021
…ype class for reading entities feature values
@morgandu morgandu force-pushed the mor--feature-store-online-read branch from 2e6d5ad to 03dd07c Compare December 17, 2021 04:31
google/cloud/aiplatform/featurestore/entity_type.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/featurestore/entity_type.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/featurestore/entity_type.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/featurestore/entity_type.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/featurestore/entity_type.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/featurestore/entity_type.py Outdated Show resolved Hide resolved
morgandu and others added 7 commits December 21, 2021 10:53
Co-authored-by: sasha-gitg <44654632+sasha-gitg@users.noreply.github.com>
Co-authored-by: sasha-gitg <44654632+sasha-gitg@users.noreply.github.com>
Co-authored-by: sasha-gitg <44654632+sasha-gitg@users.noreply.github.com>
Co-authored-by: sasha-gitg <44654632+sasha-gitg@users.noreply.github.com>
Co-authored-by: Yicheng Fang <yichengfang@google.com>
…tadata, feature_ids, _load_read_feature_values_response_to_dataframe
@morgandu morgandu requested a review from a team as a code owner December 21, 2021 19:29
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please get approval from Diem/FS team.

google/cloud/aiplatform/featurestore/entity_type.py Outdated Show resolved Hide resolved
…e conversion, update tests with explicit expected df
@morgandu morgandu changed the title feat: enable feature store online serving; add read method in EntityType class for reading entities feature values feat: enable feature store online serving Jan 15, 2022
@morgandu morgandu self-assigned this Jan 15, 2022
@morgandu morgandu added the automerge Merge the pull request once unit tests and other checks pass. label Jan 15, 2022
import pandas as pd
except ImportError:
raise ImportError(
f"Pandas are not installed. Please install pandas to use "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pandas library is not installed?

@ivanmkc
Copy link
Contributor

ivanmkc commented Jan 15, 2022

Missing PR description?

@morgandu morgandu removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 15, 2022
@morgandu morgandu added the automerge Merge the pull request once unit tests and other checks pass. label Jan 15, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit b8f5f82 into googleapis:main Jan 15, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants