Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): replace deprecated fields in create_training_pipeline_tabular_forecasting_sample.py #981

Merged
merged 6 commits into from Feb 2, 2022

Conversation

dwkk-google
Copy link
Contributor

@dwkk-google dwkk-google commented Jan 27, 2022

They have been deprecated since the Public preview since last May.

@dwkk-google dwkk-google requested review from a team as code owners January 27, 2022 07:36
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 27, 2022
@parthea parthea changed the title Update create_training_pipeline_tabular_forecasting_sample.py, replace deprecated with the updated ones. docs(samples): Update create_training_pipeline_tabular_forecasting_sample.py, replace deprecated with the updated ones. Jan 27, 2022
@parthea parthea changed the title docs(samples): Update create_training_pipeline_tabular_forecasting_sample.py, replace deprecated with the updated ones. docs(samples): replace deprecated fields in create_training_pipeline_tabular_forecasting_sample.py Jan 27, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jan 27, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 27, 2022
@ivanmkc
Copy link
Contributor

ivanmkc commented Jan 28, 2022

LGTM but can you provide context in the PR description? Have all of those parameters been renamed? Since what version?

@dwkk-google
Copy link
Contributor Author

LGTM but can you provide context in the PR description? Have all of those parameters been renamed? Since what version?

It is like this since the Public preview since last May. we have deprecate those fields back then.

@dwkk-google dwkk-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2022
Copy link
Contributor

@ivanmkc ivanmkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwkk-google dwkk-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2022
@dwkk-google dwkk-google merged commit 9ebc972 into googleapis:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants