This repository has been archived by the owner on Jul 6, 2023. It is now read-only.
fix: Remove common module
#71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
parthea
changed the title
common module
chalmerlowe
approved these changes
Apr 11, 2023
vchudnov-g
approved these changes
Apr 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the obsolete replacements in owlbot.py and the common module which was removed from googleapis/googleapis this this commit.
Note: This is a breaking change however the client is still in preview and the changes match those in googleapis/googleapis.
Remove obsolete replacements in owlbot.py. All of the replacements
s.replace()return 0 which means these are obsolete replacements. In addition, there is nocommonfolder in googleapis/googleapis here. Thecommonfolder was removed in googleapis/googleapis@8495024 however thecommonmodule was not deleted in this repository.