Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate use_regional_endpoints #199

Merged
merged 9 commits into from Dec 13, 2023
Merged

chore: deprecate use_regional_endpoints #199

merged 9 commits into from Dec 13, 2023

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Nov 13, 2023

BEGIN_COMMIT_OVERRIDE
feat: deprecate use_regional_endpoints (#199)
END_COMMIT_OVERRIDE

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated https://screenshot.googleplex.com/AtFF4YizNfdSh6F

Fixes internal issue 309021003 🦕

@shobsi shobsi requested review from a team as code owners November 13, 2023 22:22
@shobsi shobsi requested a review from tswast November 13, 2023 22:22
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 13, 2023
@shobsi shobsi requested a review from jiaxunwu November 29, 2023 20:14
@shobsi shobsi added the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2023
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2023
@shobsi shobsi added the automerge Merge the pull request once unit tests and other checks pass. label Dec 12, 2023
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 13, 2023
@shobsi shobsi merged commit 319a1f2 into main Dec 13, 2023
15 checks passed
@shobsi shobsi deleted the shobs-retire-lep branch December 13, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants