Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add DataFrame ~ operator #721

Merged
merged 2 commits into from
May 23, 2024
Merged

feat: Add DataFrame ~ operator #721

merged 2 commits into from
May 23, 2024

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@TrevorBergeron TrevorBergeron requested review from a team as code owners May 23, 2024 20:42
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 23, 2024
@TrevorBergeron TrevorBergeron requested review from chelsea-lin and removed request for tswast May 23, 2024 20:42
chelsea-lin
chelsea-lin approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please add internal bug id to the PR description?

@TrevorBergeron TrevorBergeron merged commit 354abc1 into main May 23, 2024
20 of 21 checks passed
@TrevorBergeron TrevorBergeron deleted the df_invert branch May 23, 2024 23:47
@release-please release-please bot mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees

@chelsea-lin chelsea-lin

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrevorBergeron @chelsea-lin