Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ensure "bigframes-api" label is always set on jobs, even if the API is unknown #722

Merged
merged 6 commits into from
May 24, 2024
Merged

feat: ensure "bigframes-api" label is always set on jobs, even if the API is unknown #722

merged 6 commits into from
May 24, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented May 24, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 336521938
🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 24, 2024
tswast
tswast commented May 24, 2024
View reviewed changes
bigframes/session/__init__.py
@@ -1777,12 +1783,6 @@ def _prepare_query_job_config(
bigframes.options.compute.maximum_bytes_billed
)

current_labels = job_config.labels if job_config.labels else {}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to bigframes.session._io.bigquery.create_job_configs_labels

@tswast tswast marked this pull request as ready for review May 24, 2024 18:26
@tswast tswast requested review from a team as code owners May 24, 2024 18:26
@tswast tswast requested a review from Genesis929 May 24, 2024 18:26
@tswast tswast requested a review from chelsea-lin May 24, 2024 18:26
chelsea-lin
chelsea-lin approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast
Copy link
Collaborator Author

tswast commented May 24, 2024

Failure is in third_party/bigframes_vendored/pandas/core/frame.py::frame.DataFrame.map doctest.

3919             >>> @bpd.remote_function(int, float, reuse=False)
UNEXPECTED EXCEPTION: ServiceUnavailable('502:Bad Gateway')

I'll try a re-run of the presubmit tests.

@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2024
@tswast tswast enabled auto-merge (squash) May 24, 2024 20:17
@tswast tswast merged commit 1832778 into main May 24, 2024
20 of 21 checks passed
@tswast tswast deleted the b336521938-bigframes-api-refactor-all-queries branch May 24, 2024 22:48
@release-please release-please bot mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

@Genesis929 Genesis929 Awaiting requested review from Genesis929 Genesis929 is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@Genesis929 Genesis929

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tswast @chelsea-lin @Genesis929