Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

verbosity warning is overzealous #157

Closed
craigcitro opened this issue Apr 5, 2018 · 4 comments
Closed

verbosity warning is overzealous #157

craigcitro opened this issue Apr 5, 2018 · 4 comments

Comments

@craigcitro
Copy link

I just installed 0.4.0 (馃帀), and a call to read_gbq with no verbose argument still complained at me.

I realized the issue is because pandas still provides a default.

WAI?

(/cc @tswast)

@tswast
Copy link
Collaborator

tswast commented Apr 5, 2018

Thanks for trying it out!

Oops. Yeah, we should set the default to None here. Probably worth a little 0.4.1 update for that fix.

It's still a problem for folks that use it upstream from Pandas. I'll update the default there in my PR to update the docs: pandas-dev/pandas#20564 (I started that one before I released 0.4.0, so probably due for a little refresh anyway)

@max-sixty
Copy link
Contributor

Yup, that's my fault, apologies

@craigcitro
Copy link
Author

Thanks @tswast! Are you planning an 0.4.1 update?

@tswast
Copy link
Collaborator

tswast commented Apr 6, 2018

Yep, @craigcitro. I just released to PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants