Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Conda CI build not using latest wheels? #253

Closed
tswast opened this issue Feb 22, 2019 · 1 comment · Fixed by #254
Closed

TST: Conda CI build not using latest wheels? #253

tswast opened this issue Feb 22, 2019 · 1 comment · Fixed by #254
Assignees
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Collaborator

tswast commented Feb 22, 2019

See: #247 (comment)

The Conda build is likely using an old version of pandas, even though it's supposed to be using pre-release wheels.

@tswast
Copy link
Collaborator Author

tswast commented Mar 8, 2019

I do see pandas 0.25 nightly builds on https://7933911d6844c6c53a7d-47bd50c35cd79bd838daf386af554a83.ssl.cf2.rackcdn.com/ so it's not as simple as changing the URL. Next steps to debug should probably be to print out the version of pandas in the https://github.com/pydata/pandas-gbq/blob/master/ci/run_conda.sh script.

Actually, I think I figured it out.

https://github.com/pydata/pandas-gbq/blob/8a263453e66b29dcfaed018bd0714d669bfa44e2/.circleci/config.yml#L53

should set PANDAS=MASTER if we want to use the nightlies on the conda build. Then again, maybe it's still useful to have some minimum version of pandas build. So if that's currently the oldest supported, we should make sure one of the pip builds has that pandas version.

@tswast tswast self-assigned this Mar 8, 2019
@tswast tswast added the type: process A process-related concern. May include testing, release, or the like. label Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant