Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrating off of CircleCI #638

Merged
merged 29 commits into from Jul 14, 2023
Merged

feat: migrating off of CircleCI #638

merged 29 commits into from Jul 14, 2023

Conversation

chalmerlowe
Copy link
Collaborator

@chalmerlowe chalmerlowe commented Jun 21, 2023 •
edited

Moves conda/mamba installs from the circle/ci CI/CD pipeline to github.

  • we have been aiming to get this repo off Circle/CI for a while.
  • this PR should accomplish that goal.

Summary:

  • deletes a number of circle/ci related config files
  • adds a new nox session to install the package in a conda/mamba virtual environment and run the unit tests
  • removes the noxfile.py from owlbot.py. due to the excessive amount of processing that needs to happen to the noxfile.py we made the choice to manually update the noxfile.py
  • added an edit to owlbot.py to make some changes to build.sh

NOTE:

  • the Kokoro prerelease CI/CD test is failing. This is not believed to be caused by this PR, but rather by an upstream issue in one of the dependencies and will be addressed in an alternate PR. This should not preclude this PR from being merged.
  • We expect that the failing CIRCLE/CI CI/CD test will go away once this PR is merged and all the config information is gone for good. This should also not preclude this PR from being merged.

Fixes #398 🦕

@chalmerlowe chalmerlowe added the owlbot:ignore instruct owl-bot to ignore a PR label Jun 21, 2023
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jun 21, 2023 •
edited

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-pandas API. labels Jun 21, 2023
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 23, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 23, 2023
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2023
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2023
chalmerlowe
chalmerlowe commented Jul 10, 2023
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2023
chalmerlowe
chalmerlowe commented Jul 12, 2023
View reviewed changes
noxfile.py Show resolved Hide resolved
chalmerlowe
chalmerlowe commented Jul 12, 2023
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2023
@parthea parthea added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Jul 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2023
@chalmerlowe
Copy link
Collaborator Author

Arggh.
Did not know that owlbot would remove all my changes to the build.sh file. Will update owlbot to cover build.sh (either by excluding OR by incorporating the changes).

@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2023
@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2023
@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2023
@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2023
tswast
tswast approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

noxfile.py
"""Installs packages from conda forge, pypi, and locally."""

# Install from conda-forge and default conda package repos.
session.conda_install(*conda_forge_packages, channel=["defaults", "conda-forge"])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If both default and conda-forge have a package, would we get the version from conda-forge or default? IMO, we should prefer conda-forge since those packages are updated more frequently in general.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I don't know the answer yet. I will look it up and see if there is a way to identify a preference for source.

Not gonna hold up the PR for this though. If a change is needed, will add to a separate PR.

@chalmerlowe chalmerlowe merged commit 08fe090 into main Jul 14, 2023
22 of 24 checks passed
@chalmerlowe chalmerlowe deleted the circleci-migration branch July 14, 2023 15:25
@release-please release-please bot mentioned this pull request Jul 14, 2023
Merged
@meredithslota meredithslota changed the title feat: migrating off of circle/ci feat: migrating off of CircleCI Aug 22, 2023
@meredithslota meredithslota mentioned this pull request Aug 23, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@GaoleMeng GaoleMeng Awaiting requested review from GaoleMeng GaoleMeng is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add session to noxfile that installs dependencies via conda
4 participants
@chalmerlowe @tswast @parthea @yoshi-kokoro