Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: edit units for time in tests #655

Merged
merged 20 commits into from
Aug 16, 2023
Merged

fix: edit units for time in tests #655

merged 20 commits into from
Aug 16, 2023

Conversation

chalmerlowe
Copy link
Collaborator

@chalmerlowe chalmerlowe commented Jul 20, 2023 •
edited
Loading

A number of tests are failing due to a timestamp precision mismatch.
This fixes those mismatches.

Fixes #643
Fixes #644
Fixes #645
Fixes #646
Fixes #647
Fixes #648
Fixes #649

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-pandas API. labels Jul 20, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 20, 2023
chalmerlowe
chalmerlowe commented Aug 4, 2023
View reviewed changes
tests/system/test_gbq.py Outdated Show resolved Hide resolved
chalmerlowe
chalmerlowe commented Aug 7, 2023
View reviewed changes
tests/system/test_gbq.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: s Pull request size is small. labels Aug 8, 2023
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: u Pull request is empty. labels Aug 11, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Aug 15, 2023
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Aug 16, 2023
@chalmerlowe chalmerlowe marked this pull request as ready for review August 16, 2023 16:51
@chalmerlowe chalmerlowe requested review from a team as code owners August 16, 2023 16:51
@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2023
@chalmerlowe chalmerlowe merged commit d4ebb0c into main Aug 16, 2023
25 checks passed
@chalmerlowe chalmerlowe deleted the fix-timestamp-precision branch August 16, 2023 18:52
@release-please release-please bot mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@jainsahab jainsahab Awaiting requested review from jainsahab jainsahab is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
2 participants
@chalmerlowe @shollyman