Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade sql-alchemy version to at least 1.4.29 #477

Closed
ihvol-freenome opened this issue Jul 27, 2022 · 1 comment
Closed

upgrade sql-alchemy version to at least 1.4.29 #477

ihvol-freenome opened this issue Jul 27, 2022 · 1 comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. status: duplicate Duplicate. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ihvol-freenome
Copy link

ihvol-freenome commented Jul 27, 2022

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.
yes. current requirement for sql-alchemy is >=1.2.0,<=1.4.27 and sql-alchemy version 1.4.27 has this issue. we can't upgrade sql-alchemy because of this dependency.
Describe the solution you'd like
Please upgrade the sql-alchemy to at least 1.4.29 version which has a fix for the issue described above.
Describe alternatives you've considered
alternative workaround would be # type: ignore to ignore the entire file, but that doesn't comply with our code quality policy and we can't use it.
Additional context
Here is the full trace...

version: 0.961
Traceback (most recent call last):
  File "mypy/semanal.py", line 5350, in accept
  File "mypy/nodes.py", line 1165, in accept
  File "mypy/semanal.py", line 2109, in visit_assignment_stmt
  File "mypy/semanal.py", line 2395, in apply_dynamic_class_hook
  File "/fn/lib/python3.9/site-packages/sqlalchemy/ext/mypy/plugin.py", line 145, in _dynamic_class_hook
    obj = ctx.api.named_type("__builtins__.object")
  File "mypy/semanal.py", line 4720, in named_type
  File "mypy/semanal.py", line 4687, in lookup_fully_qualified
AssertionError: __builtins__.object
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Jul 27, 2022
@meredithslota
Copy link

This is temporarily blocked by some failing tests, please see here for additional info: #385 I'm going to close this issue as a duplicate of that issue, and I hope we can prioritize this soon.

@meredithslota meredithslota added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. status: duplicate Duplicate. labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. status: duplicate Duplicate. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants