Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous docs now that there are >1 endpoints supported #18

Closed
tswast opened this issue Mar 3, 2020 · 5 comments
Closed

Ambiguous docs now that there are >1 endpoints supported #18

tswast opened this issue Mar 3, 2020 · 5 comments
Assignees
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. type: docs Improvement to the documentation for an API.

Comments

@tswast
Copy link
Contributor

tswast commented Mar 3, 2020

image

It's impossible to tell which is the v1beta1 API and which is the v1 API. Doc title needs to include the version.

@busunkim96
Copy link
Contributor

This should be fixed upstream in the generator templates. Filed an issue https://github.com/googleapis/gapic-generator/issues/3108

@busunkim96 busunkim96 added the type: docs Improvement to the documentation for an API. label Mar 3, 2020
@plamut plamut added external This issue is blocked on a bug with the actual product. and removed external This issue is blocked on a bug with the actual product. labels Mar 10, 2020
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. label Jul 10, 2020
@meredithslota
Copy link

Root cause fixed in googleapis/gapic-generator-python#435 but will check to see if that fix has made its way through to here. :)

@meredithslota
Copy link

@busunkim96
Copy link
Contributor

busunkim96 commented Sep 29, 2020

I believe this is because v1 is the only endpoint https://github.com/googleapis/python-bigquery-storage/tree/master/google/cloud

This will work as expected if a new version is added. See dataproc for an example.

image

@tswast
Copy link
Contributor Author

tswast commented Oct 20, 2020

Closing as we dropped the v1beta1 client in the 2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

No branches or pull requests

4 participants