feat: add support dataset.max_time_travel_hours #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
bot
added
size: s
Gaurang033
force-pushed
the
main
branch
5 times, most recently
from
4241cc1
to
af2be4c
Compare
Linchin
added
the
kokoro:force-run
Linchin
reviewed
Oct 18, 2023
Linchin
reviewed
Oct 18, 2023
yoshi-kokoro
removed
the
kokoro:force-run
Gaurang033
force-pushed
the
main
branch
2 times, most recently
from
3fc636f
to
535c982
Compare
product-auto-label
bot
added
size: m
Gaurang033
force-pushed
the
main
branch
2 times, most recently
from
114955e
to
535c982
Compare
product-auto-label
bot
added
size: s
Gaurang033
force-pushed
the
main
branch
3 times, most recently
from
670de48
to
56f9dbe
Compare
product-auto-label
bot
added
size: m
|
@Linchin added units tests. |
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Linchin
reviewed
Oct 30, 2023
google/cloud/bigquery/dataset.py
Outdated
| @max_time_travel_hours.setter | ||
| def max_time_travel_hours(self, hours): | ||
| if not isinstance(hours, int): | ||
| raise ValueError("Pass the int value") |
There was a problem hiding this comment.
nit: make the error message a little clearer such as saying f"max_time_travel_hours must be an integer. Got {hour}.".
There was a problem hiding this comment.
@Linchin done and added a unit tests for that as well.
google/cloud/bigquery/dataset.py
Outdated
| return cls(role, entity_type, entity_id) | ||
| config = cls(role, entity_type, entity_id) | ||
| config._properties = copy.deepcopy(resource) | ||
| return config |
There was a problem hiding this comment.
Could you please explain why this change is necessary?
There was a problem hiding this comment.
@Linchin this function should not be changed. Thanks for catching it. I reverted it back.
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Linchin
requested changes
Oct 31, 2023
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Thank you @Gaurang033! |
Linchin
approved these changes
Oct 31, 2023
This was referenced Dec 5, 2023
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1637