docs: Updates query to query and wait in client_query_w_positional_params.py
#1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
馃 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
the
api: bigquery
kiraksi
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
kiraksi
requested review from
tswast
and removed request for
parthea and
GaoleMeng
kiraksi
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tswast
requested changes
Jan 25, 2024
| @@ -35,7 +35,9 @@ def client_query_w_positional_params() -> None: | |||
| bigquery.ScalarQueryParameter(None, "INT64", 250), | |||
| ] | |||
| ) | |||
| query_job = client.query(query, job_config=job_config) # Make an API request. | |||
| query_job = client.query_and_wait( | |||
There was a problem hiding this comment.
Please rename this variable, as the return value is no longer a QueryJob object. Instead it is a RowIterator object. "rows" or "results" could be a good name.
There was a problem hiding this comment.
Yes, sounds good. Will correct that now.
tswast
reviewed
Jan 25, 2024
| query_job = client.query(query, job_config=job_config) # Make an API request. | ||
| results = client.query_and_wait( | ||
| query, job_config=job_config | ||
| ) # Make an API request. | ||
|
|
||
| for row in query_job: |
There was a problem hiding this comment.
This line needs to be updated too. The query_job variable doesn't exist anymore.
There was a problem hiding this comment.
Yes, will correct now.
tswast
added
kokoro:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:run
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 馃