Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update to_geodataframe to use query_and_wait functionality #1800

Merged
merged 6 commits into from Jan 29, 2024
Merged

docs: update to_geodataframe to use query_and_wait functionality #1800

merged 6 commits into from Jan 29, 2024
+1 −1

Conversation

DevStephanie
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@DevStephanie DevStephanie requested review from a team as code owners January 25, 2024 20:04
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jan 25, 2024
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 26, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 26, 2024
@kiraksi kiraksi changed the title Edits docs: update samples client_query_w_timestamp_params.py and to_geodataframe to use query_and_wait functionality Jan 29, 2024
@kiraksi kiraksi requested review from kiraksi and removed request for dandhlee and obada-ab January 29, 2024 01:10
@kiraksi kiraksi changed the title docs: update samples client_query_w_timestamp_params.py and to_geodataframe to use query_and_wait functionality docs: update to_geodataframe to use query_and_wait functionality Jan 29, 2024
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2024
kiraksi
kiraksi approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@kiraksi kiraksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiraksi kiraksi merged commit 1298594 into googleapis:main Jan 29, 2024
19 checks passed
@release-please release-please bot mentioned this pull request Jan 29, 2024
Merged
This was referenced Feb 13, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiraksi kiraksi kiraksi approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DevStephanie @kiraksi @yoshi-kokoro