Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change load_table_from_json autodetect logic #1804

Merged
merged 2 commits into from Jan 30, 2024

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented Jan 29, 2024

Replaces #1801, for more details, see discussions in #1228.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1228 #1563 馃

@Linchin Linchin requested review from a team as code owners January 29, 2024 23:22
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jan 29, 2024
@Linchin Linchin requested a review from tswast January 29, 2024 23:43
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This should make the BigQuery API much more usable.

@Linchin Linchin merged commit 6249032 into googleapis:main Jan 30, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load_table_from_json interpolates string as int
2 participants