Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support range sql #1807

Merged
merged 9 commits into from Mar 7, 2024
Merged

feat: support range sql #1807

merged 9 commits into from Mar 7, 2024

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented Jan 30, 2024

Part of #1724.

Supports User Defined Functions with RANGE type parameters.

@Linchin Linchin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 30, 2024
@Linchin Linchin requested review from a team as code owners January 30, 2024 20:07
@Linchin Linchin requested a review from mrfaizal January 30, 2024 20:07
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jan 30, 2024
@Linchin Linchin removed the request for review from mrfaizal January 30, 2024 20:07
@Linchin Linchin marked this pull request as draft January 30, 2024 20:07
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Feb 27, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Feb 27, 2024
@Linchin Linchin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 6, 2024
@Linchin Linchin marked this pull request as ready for review March 6, 2024 01:01
@Linchin Linchin requested a review from shollyman March 6, 2024 01:04
@Linchin Linchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2024
@@ -292,6 +293,7 @@ class SqlTypeNames(str, enum.Enum):
TIME = "TIME"
DATETIME = "DATETIME"
INTERVAL = "INTERVAL" # NOTE: not available in legacy types
RANGE = "RANGE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the comment for INTERVAL about legacy availability also true for RANGE?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the legacy types here refer to the types supported by legacy SQL? In that case, it is indeed not supported. If so, I will add the comment here.

@Linchin Linchin enabled auto-merge (squash) March 7, 2024 00:33
@Linchin Linchin merged commit 86a45c9 into googleapis:main Mar 7, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants