Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand the list of dependencies to run pre-release tests against #886

Closed
plamut opened this issue Aug 19, 2021 · 0 comments · Fixed by #948
Closed

Expand the list of dependencies to run pre-release tests against #886

plamut opened this issue Aug 19, 2021 · 0 comments · Fixed by #948
Assignees
@plamut
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: process A process-related concern. May include testing, release, or the like.

Comments

@plamut
Copy link
Contributor

plamut commented Aug 19, 2021

Context: #885

BigQuery Python client implicitly depended on pytz - this dependency was installed via google-api-core dependency. However, when google-api-core dropped pytz in the 2.0 release, users that upgraded that dependency suddenly started seeing import errors.

This should have been caught by pre-release tests, but at the moment we only do so for pyarrow, pandas, and grpcio dependencies. As discussed offline, this list should be extended with at least google-api-core and google-clod-core dependencies.
@plamut plamut added the type: process A process-related concern. May include testing, release, or the like. label Aug 19, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Aug 19, 2021
@plamut plamut self-assigned this Sep 7, 2021
@plamut plamut mentioned this issue Sep 7, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: add more dependencies to pre-release tests plamut/python-bigquery
1 participant
@plamut