Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure mypy passes #448

Merged
merged 27 commits into from
Oct 14, 2021
Merged

chore: ensure mypy passes #448

merged 27 commits into from
Oct 14, 2021

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Oct 13, 2021

related to #447

mypy -p google.cloud.bigtable --no-incremental
Success: no issues found in 17 source files

For bigtable, specifying a subfolder fails, but package works fine. Ignoring for now

❯ ./.nox/unit-3-10/bin/mypy google/cloud/bigtable
google/cloud/bigtable/__init__.py: error: Source file found twice under different module names: "cloud.bigtable.client" and "google.cloud.bigtable.client"
Found 1 error in 1 file (errors prevented further checking)

@crwilcox crwilcox requested review from a team as code owners October 13, 2021 18:13
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Oct 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2021
@tswast
Copy link
Contributor

tswast commented Oct 13, 2021

Do you want to add a nox session for this?

Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be adding a mypy nox session?

google/cloud/bigtable/__init__.py Show resolved Hide resolved
google/cloud/bigtable/client.py Outdated Show resolved Hide resolved
google/cloud/bigtable/client.py Outdated Show resolved Hide resolved
@crwilcox
Copy link
Contributor Author

This can merge, but bug should have a comment added that we want to evaluate mypy against google and tests (comment in code)

This PR needs to merge to remove a class of errors from generated code https://www.github.com/googleapis/gapic-generator-python/issues/1026

@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2021
google/cloud/bigtable/table.py Outdated Show resolved Hide resolved
google/cloud/bigtable/table.py Show resolved Hide resolved
Remove '_CLIENT_INFO' from module scope.
@google-cla
Copy link

google-cla bot commented Oct 14, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 14, 2021
@tseaver
Copy link
Contributor

tseaver commented Oct 14, 2021

@googlebot I consent

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 14, 2021
@tseaver
Copy link
Contributor

tseaver commented Oct 14, 2021

@googlebot I consent.

@crwilcox
Copy link
Contributor Author

Seems a small coverage gap

google/cloud/bigtable/table.py                                                                 283      0     80      1    99%   64->63

@tseaver
Copy link
Contributor

tseaver commented Oct 14, 2021

65a472b closes that gap.

@crwilcox crwilcox merged commit a99bf88 into main Oct 14, 2021
@crwilcox crwilcox deleted the mypy branch October 14, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants