fix: Ensure message fields are copied when building retry request #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the to_dict() function when building the ReadRowsRequest arguments. This way, all available fields in the message will get copied over. The `message.filter` field needed a special handling, since the to_dict() function doesn't seem to parse the value the way we want it to be. Fixes internal bug #214449800
product-auto-label
bot
added
the
api: bigtable
Mariatta
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
copy_from doesn't copy over "empty" fields, so had to adjust the test case expected values.
igorbernstein2
requested changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the copy_from() function when building the ReadRowsRequest arguments.
Fixes internal bug #214449800
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #214449800 馃